-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to specify default tolerations via the buildconfig defaulter #6579
Ability to specify default tolerations via the buildconfig defaulter #6579
Conversation
@bparees is there any kind of test that I can/need to add for the buildoverride tolerations? |
not that i'm aware of. @sdodson or @ewolinetz would know better. But you should manually test it, at a minimum. |
/retest |
The CI jobs will just ensure you haven't broken the default case, it won't exercise that this change actually takes effect though. |
@bparees @sdodson ptal resulted in this being added to my /etc/origin/master/master-config.yaml file
And creating a new application via
|
/lgtm |
/retest |
/retest |
3 similar comments
/retest |
/retest |
/retest |
@sdodson Can I get another lgtm please? I didn't change anything I just rebased, and all tests are passing now. |
/lgtm |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest |
Automatic merge from submit-queue. |
@coreydaley: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Trello: https://trello.com/c/LNxlMjjU/1435-5-ability-to-specify-default-tolerations-via-the-buildconfig-defaulter-builds
Dependent on:
openshift/origin#17955